Merge branch 'feat/step6-success-rate' into feat/step3-missing-guidance

cypher-executor/src/actions/cypher-handlers.ts

@@ -3,7 +3,7 @@ import { ExecutionError, WorkflowPaused } from '../types';
 import { GraphExecutor } from '../graph-executor';
 import { graphSchema } from '../lib/schemas';
 import { createComponentLoader } from '../lib/component-loader';
-import { writeEvaluation, updateComponentStats } from './execution-evaluator';
+import { recordComponentStats } from './execution-evaluator';
 import { parseTriplets } from './triplet-parser';
 import { searchNodes, type SearchMode, type SearchTarget } from './search-nodes';
 import { buildExecutionGraph } from './graph-builder';
@@ -77,18 +77,8 @@ export async function handleCypherExecute(
     const result = await executor.execute(parseResult.data as ExecutionGraph, context ?? {}, env.EXEC_CONTEXT);
     const duration_ms = Date.now() - start;
 
-    // 非同步記錄統計（Phase 7 補充 analytics，目前為 no-op）
-    const componentId = graph.nodes.find(n => n.componentId)?.componentId ?? graphId;
-    const runId = `${graphId}-${Date.now()}`;
-    waitUntil(writeEvaluation(env, {
-      run_id: runId,
-      workflow_id: graphId,
-      component_id: componentId,
-      verdict: 'success',
-      duration_ms,
-      evaluated_at: Date.now(),
-    }));
-    waitUntil(updateComponentStats(env, componentId, 'success', duration_ms));
+    // 非同步回寫每顆零件的執行統計（design.md「執行統計設計」；fire-and-forget 不阻擋回應）
+    waitUntil(recordComponentStats(env, graph.nodes, result.trace));
 
     return { success: true, data: result.data, trace: result.trace, duration_ms, graph };
   } catch (err) {
@@ -110,19 +100,10 @@ export async function handleCypherExecute(
     }
 
     const errMsg = err instanceof Error ? err.message : String(err);
-    const componentId = graph.nodes.find(n => n.componentId)?.componentId ?? graphId;
-    const runId = `${graphId}-${Date.now()}`;
-    waitUntil(writeEvaluation(env, {
-      run_id: runId,
-      workflow_id: graphId,
-      component_id: componentId,
-      verdict: 'failed',
-      duration_ms,
-      error_message: errMsg.slice(0, 200),
-      evaluated_at: Date.now(),
-    }));
-    waitUntil(updateComponentStats(env, componentId, 'failed', duration_ms));
+    // 失敗路徑同樣回寫每顆零件統計：ExecutionError 帶完整 trace（失敗節點有 error、
+    // 之前成功的節點照記成功）；非 ExecutionError 無 trace 可歸因 → 不記（誠實：不瞎猜）。
     if (err instanceof ExecutionError) {
+      waitUntil(recordComponentStats(env, graph.nodes, err.trace));
       const traceFormatted = err.trace.map(s => ({
         node: s.nodeId,
         status: s.error ? 'failed' : 'success',